Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve admin shifts #1079

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve admin shifts #1079

wants to merge 5 commits into from

Conversation

ximex
Copy link
Contributor

@ximex ximex commented Jan 27, 2023

  • improve size of start/end date
  • use enum's instead of string values
    • use strict checks there
    • better variable naming
  • better shift_over_midnight check

@ximex
Copy link
Contributor Author

ximex commented Feb 3, 2023

@MyIgel @weeman1337 ready for review/merge

@MyIgel
Copy link
Member

MyIgel commented Mar 10, 2023

❗ This is another change of legacy code that needs extensive testing at some point

@MyIgel MyIgel added the Status: Needs discussion Additional discussion/feedback is needed label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs discussion Additional discussion/feedback is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ximex @MyIgel