Flat-based objects positioned correctly #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jf-kelly
requested review from
a team,
rjmara,
bryanmontalvan and
nkisari
and removed request for
a team
jf-kelly
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes (to
setPosition()andsetYPos()) make it so that objects with flat bases (box(),cylinder(), etc.) are positioned correctly on the floor when y is set to 0. This was a problem caused by scaling, since the position is set based on the center of the object, which does not change when the scale is changed. So, that is why there were issues with objects being set at y=0, yet not actually being aligned on the ground.As of now, this fix only works for objects with flat bases, but it seems to be an improvement on the current functions in production.
Preview
Related Issue
#604