Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkman integration #466

Closed
wants to merge 1 commit into from
Closed

darkman integration #466

wants to merge 1 commit into from

Conversation

MoetaYuko
Copy link
Contributor

fixes #447, much easier than I expected thanks to existing infra

needs #459 which introduced geoclue as a hard dependency of gammastep

users can edit .config/darkman/config.yaml to disable auto transition

@MoetaYuko
Copy link
Contributor Author

@end-4 any comments on this feature? feel free to close if not worth adding.

@end-4
Copy link
Owner

end-4 commented May 30, 2024

ugh... i'm hesitant to add this since there's already blue light filter and one can always change the brightness if needed

if we add this feature i think i can just give the dark mode toggle an "Auto" mode and make a new user option in case someone wants to enable/disable it by default without digging in hyprland config
thank you for your work

@end-4 end-4 closed this May 30, 2024
@MoetaYuko
Copy link
Contributor Author

darkman has two major advantages:

  1. retrieve geolocation-based transition time from geoclue (like gammastep does)
  2. run custom user scripts. e.g., I have additional scripts to switch gtk/qt/kvantum themes between light/dark variants

anyway, whoever needs this can cherry-pick in their fork.

@clsty
Copy link
Collaborator

clsty commented May 30, 2024

I actually kinda like this PR... @end-4 maybe reconsider this one? That autorun-theme-changing-custom-script feature sounds great. Of course it's your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] darkman integration
3 participants