Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more clear to add django_filters to INSTALLED_APPS #7535

Merged
merged 2 commits into from Sep 14, 2020
Merged

Make it more clear to add django_filters to INSTALLED_APPS #7535

merged 2 commits into from Sep 14, 2020

Conversation

johnthagen
Copy link
Contributor

Description

Make it more clear that 'django_filters' needs to be installed into INSTALLED_APPS to help users avoid this common mistake: carltongibson/django-filter#562 (comment)

It's currently easy to breeze past that part in the docs because it is directly before a pip install step.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. Seems reasonable. (I forgot to do that myself only this week... 🙂)

@carltongibson carltongibson merged commit e17779c into encode:master Sep 14, 2020
@johnthagen johnthagen deleted the patch-1 branch September 14, 2020 17:51
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants