Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRQ-11247: Added fontScale prop for large text mode scale values #3217

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

WRQ-11247: Added fontScale prop for large text mode scale values #3217

wants to merge 12 commits into from

Commits on Mar 4, 2024

  1. Implemented to update base font size when fontScale changes 

    Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    059009a View commit details
    Browse the repository at this point in the history

  2. Revert Api that was unnecessarily changed to public to private 

    Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    60cd8d6 View commit details
    Browse the repository at this point in the history

  3. Specified fontScale default value in calculateFontSize 

    Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7edf27d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fixed lint warning 

    Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    dc800af View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Applied reviews 

    - Added fontScale to defaultConfig of ResolutionDecorator
- Deleted fontScale to prevent it from being passed to Wrapped.

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0166ae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Applied reviews 

    - Moved fontScale to defaultProps from defaultConfig
- Modified it so that fontScale is  applied on initial entry

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a371997 View commit details
    Browse the repository at this point in the history

  2. Modified the fontScale value to be managed by resolution internal var… 

    …iable

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4b93d18 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Applied review 

    - Moved updateFontScale to constructor

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a1b27c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge branch 'develop' into feature/large-text

    @mmyelyn
    mmyelyn committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    09fe9d2 View commit details
    Browse the repository at this point in the history

  2. Modified so that fontScale can be applied when adjusting the scale value 

    regardless of the base font.

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7efab79 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Added fontScale to config of ResolutionDecorator 

    - FontScale must be updated before the scale function is called

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
    @mmyelyn
    mmyelyn committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5308615 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'develop' into feature/large-text

    @mmyelyn
    mmyelyn committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7d442c5 View commit details
    Browse the repository at this point in the history