Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add default values to settings doc page #21943

Merged
merged 2 commits into from
May 14, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented May 14, 2024

This adds Default value: .. for each setting. Example output:

settings_default

Context: Recent discussion on finding the default values: https://groups.google.com/g/emscripten-discuss/c/SjoruKoQ2SM/m/R_HYP1ELAwAJ

@kripken kripken requested a review from sbc100 May 14, 2024 17:09
@kripken
Copy link
Member Author

kripken commented May 14, 2024

After applying the feedback I noticed that this does not handle one setting, which has a multi-line value. I added a TODO for it.

@kripken kripken merged commit 8cc1654 into emscripten-core:main May 14, 2024
29 checks passed
@kripken kripken deleted the docs.default.settings branch May 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants