[wasm64] Fix _emscripten_run_callback_on_thread under wasm64

[sbc100]

The only test we have for this was in test_interactive.py. I ran it locally to ensure it now works.

Fixes: #21851

[dschuff]

The code and test changes look fine. Do you think it would be possible to move some of this event-threading coverage out of interactive tests? Presumably things like key or mouse events would have to stay interactive but maybe for proxying we could move to some other kind of event?

[sbc100]

The code and test changes look fine. Do you think it would be possible to move some of this event-threading coverage out of interactive tests? Presumably things like key or mouse events would have to stay interactive but maybe for proxying we could move to some other kind of event?

Actually it looks like we do already have some coverage in the browser tests for this and the test was explictly disabled for wasm64. Now enabled!

[jspanchu]

Upon pasting that last line in tools/emscripten.py, mouse/keyboard/resize all work great in wasm64 + proxy-to-pthread! Assuming this gets merged, will this fix make it to the next release 3.1.59? Any rough estimate when that will happen?

Thanks for working on this!

[sbc100]

Upon pasting that last line in tools/emscripten.py, mouse/keyboard/resize all work great in wasm64 + proxy-to-pthread! Assuming this gets merged, will this fix make it to the next release 3.1.59? Any rough estimate when that will happen?

Thanks for working on this!

3.1.59 is already in the process of being built, so this would go into 3.1.60.

BTW you can always use emsdk install tot to get the very largest version of emscripten (usually lags just a few hours).

[jspanchu]

Can an entry please be made for this bug fix in the changelog for 3.1.60 (in development). Thanks. I usually look at the ChangeLog to find interesting bug fixes/features before updating our emsdk version.

[sbc100]

Given that wasm64 is itself still experimental I wouldn't normally put something like this in the ChangeLog. I'm happy to make an exception though if you think this will be useful to others too?

[sbc100]

Given that wasm64 is itself still experimental I wouldn't normally put something like this in the ChangeLog. I'm happy to make an exception though if you think this will be useful to others too?

(we normally reserve the ChangeLog for major changes or breaking changes, not bugfixes like this)

[jspanchu]

Okay. I don't know of others interested in rendering and event processing with 64-bit wasm outside of the simulation post processing industry, anyone from gaming?

It seems fair enough to leave it out.

[sbc100]

BTW the 3.1.60 release should get done today or tomorrow I hope.

[jspanchu]

Awesome!