Ensure all unused elements are removed during applyDCEGraphRemovals. NFC #21840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
applyDCEGraphRemovals
branch
4 times, most recently
from
c2e4b15
to
6698bc6
Compare
kripken
reviewed
Apr 29, 2024
sbc100
force-pushed
the
applyDCEGraphRemovals
branch
3 times, most recently
from
8e901f1
to
e458f10
Compare
kripken
approved these changes
Apr 30, 2024
There were bugs in `applyDCEGraphRemovals` that were preventing it from finding certain unused exports in certain cases. This change cleanup up the pass and adds assertions that all unused imports and exports are actually located and removed, thus preventing these types of bugs from sneaking in again. The test we had for `applyDCEGraphRemovals` were worked, but they were writing in a slightly different style to the current emscripten output. In particular the export name and JS name were matching, even though the actual compiler output produces JS names that contain a leading underscore. I also updates the tests to match this style for consistency. I believe the effects of this bug were not captured by our code size tests because they all run closure compiler afterwards which was removing the unused exports itself.
sbc100
force-pushed
the
applyDCEGraphRemovals
branch
from
e458f10
to
eaef669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were bugs in
applyDCEGraphRemovalsthat were preventing it from finding certain unused exports in certain cases.This change cleanup up the pass and adds assertions that all unused imports and exports are actually located and removed, thus preventing these types of bugs from sneaking in again.
The test we had for
applyDCEGraphRemovalswere worked, but they were writing in a slightly different style to the current emscripten output. In particular the export name and JS name were matching, even though the actual compiler output produces JS names that contain a leading underscore. I also updates the tests to match this style for consistency.I believe the effects of this bug were not captured by our code size tests because they all run closure compiler afterwards which was removing the unused exports itself.