Remove most usage of withStackSave. NFC #21764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 15, 2024
| } | ||
| var rtn = __emscripten_run_on_main_thread_js(funcIndex, emAsmAddr, serializedNumCallArgs, args, sync); | ||
| stackRestore(sp); | ||
| return rtn; |
There was a problem hiding this comment.
Maybe withStackSave is worth it for convenience in cases like this, to avoid the annoyance of a temp var?
There was a problem hiding this comment.
Maybe.. although I think this is the change that actually shows up as a saving in our code size tests.. so I'm tempted to keep it.
There was a problem hiding this comment.
If it's shorter that's good enough for me I guess...
The remaining usage is all in library_wasmfs.js where it make the code a fair amount more readable to continue to use `withStackSave()` See emscripten-core#21763
kripken
approved these changes
Apr 15, 2024
| } | ||
| var rtn = __emscripten_run_on_main_thread_js(funcIndex, emAsmAddr, serializedNumCallArgs, args, sync); | ||
| stackRestore(sp); | ||
| return rtn; |
There was a problem hiding this comment.
If it's shorter that's good enough for me I guess...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining usage is all in library_wasmfs.js where it make the code a fair amount more readable to continue to use
withStackSave().See #21763