Document -sWASM_WORKERS=2 build mode better. #21614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted directly in code in https://github.com/emscripten-core/emscripten/blob/8b180923ccc1f1e05688f76bd935675d7e7c8ff1/src/library_wasm_worker.js#L130-L134 , but was not that discoverable. Closes emscripten-core#21609.
sbc100
reviewed
Mar 26, 2024
| // file a.ww.js will be generated to bootstrap the Wasm Worker JS contexts. | ||
| // If 2, enables support for Wasm Workers, but without using a separate a.ww.js | ||
| // file on the side. This can simplify deployment of builds, but will have a | ||
| // downside that the generated build will no longer be csp-eval compliant. |
There was a problem hiding this comment.
This sounds like just embedding the worker JS boostrap file inside the main JS file. However, in the other issue regarding this it sounded like i also related the generated html file. Am I misunderstanding something?
There was a problem hiding this comment.
Yeah, -sWASM_WORKERS=2 mode embeds the .ww.js file into the main .js file.
Commented in #17547 (comment) for more overview, maybe that helps.
sbc100
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document -sWASM_WORKERS=2 build mode better. It was previously documented directly in code in
emscripten/src/library_wasm_worker.js
Lines 130 to 134 in 8b18092