Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty folders #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow empty folders #112

wants to merge 2 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented Mar 5, 2021

This allows you to delete the page folder and also the tag folder without the build exploding. This doesn't go so far as allowing you to also delete the content folder or the author folders because those are pretty required i.e. the app will not work without these 馃槀

If we think this doesn't go far enough we could add a quick check to the index.js file to give a more sensible error when they try to build without any content or authors 馃憤

@elwayman02
Copy link
Contributor

I think a sensible error would be nice, because some users will probably aggressively delete the sample content/authors generated by the blueprint and forget to generate new ones.

@elwayman02
Copy link
Contributor

elwayman02 commented Mar 5, 2021

Also, I think that the app should still be able to build without content. It's just a blog with no posts, which is how every blog starts. The app should still run and show the page structure, IMO. Someone who's first setting up a blog might want to work on page content first, adding and About page or other things to the navigation before they've written any blog posts. That app should still build and be deployable even though it doesn't have any content. And if there's no content, there may not be any authors yet. So I do think that's a valid use-case that should be supported.

@elwayman02
Copy link
Contributor

That said, I do think that it's unlikely we'd ever want to delete the content and author folders permanently, which IMO means the correct approach for those two directories is to use gitkeep so they for sure exist even when empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants