Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Stylis #2587

Closed
Closed

Conversation

michal-perlakowski
Copy link

Fixes #2392.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021

⚠️ No Changeset found

Latest commit: daac871

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit daac871:

Sandbox Source
Emotion Configuration

@Andarist
Copy link
Member

Any particular reason that you have closed this? Should I recreate this in a new PR?

@michal-perlakowski
Copy link
Author

@Andarist Some of the tests are failing. I think the changes in Stylis introduced some bugs. I don't have time to look more into it right now.

@Andarist
Copy link
Member

I've investigated those test failures - they were legit. A patch has been released to Stylis and I've prepared a PR upgrading Stylis version here: #2590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty @keyframes declaration is removed in production mode
2 participants