Add set_mouse_pos function
#321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
emoon
reviewed
Jun 13, 2023
src/os/windows/mod.rs
Outdated
| unsafe { | ||
| let pos = self.get_position(); | ||
|
|
||
| winuser::SetCursorPos(left as i32 + pos.1 as i32, top as i32 + pos.0 as i32 + 30 /* height of title bar */); |
There was a problem hiding this comment.
I don't think hard coding height to 30 here is a good idea. The window may not have a title bar, or the user may have increased / decreased the font size of the title bar.
|
Thanks for the PR. I can't merge this one yet tho as I strive to have the same functionally across all backends to not confuse users. |
|
Titlebar height is not hardcoded anymore. I can't code for other platforms though as I only have a windows device. Hope you get somewhere with the code if you find the time! |
|
Thanks! I will try to get around implementing the other platforms also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only works on windows though