Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic to check for settings.ini first #1549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update logic to check for settings.ini first #1549

wants to merge 1 commit into from

Conversation

Twincarb
Copy link
Contributor

@Twincarb Twincarb commented Apr 3, 2020

Updating/Reversing the logic for which settings file to check for, if I am correct we are now using the settings.ini file so it should be checked for before settings.php

removed comments that are repeating the code

edited the error title to be specific on what is missing.

Updating/Reversing the logic for which settings file to check for, if I am correct we are now using the settings.ini file so it should be checked for before settings.php

edited the error title to be specific on what is missing.
@borpin
Copy link
Contributor

borpin commented Apr 3, 2020

The issue here is that a new system (which will have a settings.ini file), that imports a backup, will then use the wrong settings file as the import of a backup brings across what might be a settings.php file from the system backed up.

What we need is a means of transferring the settings.php to a settings.ini file to complete the migration. Ideally only the settings that are different to the default should be included in the settings.ini file.

Even better would be a means of editing settings from the UI.

For now it should stay as-is.

@Twincarb
Copy link
Contributor Author

Twincarb commented Apr 3, 2020

@borpin that does explain why it is the way around that it is, I havent looked to see what is saved in the backup, its possible that the restore script could be made to handle the conversion to settings.ini But that is outside of this PR.

I agree with having the ability of editting of settings in the UI would be handy...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants