Support for user_capabilities module - invasive changes - do NOT merge #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 25, 2019 09:32
Remove "edit buttons" from view depending on write capability
Interaction of input list with no access to feed data is still weird
|
Thanks @lvogt for contributing this and apologies for the slow reply, I will continue to keep this open for now until we get a chance in future to review properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
this adds some simple support for the user capabilities module. However, the changes are very significant as the default retracts pretty much all access to input, feed and device modules. (Obviously, only test this in a non-crictical environment...)
Maybe someone else finds some use for this, too.
I already liked to my fork in an issue at the capabilities module, but I expect visibility with this PR is better..
takkaria/emoncms-user-capabilities#5