Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop wlr.portal #295

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Drop wlr.portal #295

wants to merge 1 commit into from

Conversation

emersion
Copy link
Owner

xdg-desktop-portal has a new way to find portal implementations now.

@emersion
Drop wlr.portal
170a920 
xdg-desktop-portal has a new way to find portal implementations now.
@emersion
Copy link
Owner Author

Hm, is the whole portal file the right thing to do? Is it now unused? Should we just drop the UseIn part instead?

@alebastr
Copy link
Contributor

wlr.portal is still used to resolve wlr in portals conf and determine supported implementations for

[preferred]
default=wlr;gtk

UseIn= will be used as a fallback when portals.conf does not define an implementation for a certain portal.
E.g. contrib/wlroots-portals.conf in this repo does not have an entry for ScreenCast and default=gtk doesn't implement it, but things work because UseIn fallback lookup returns wlr.

@emersion emersion marked this pull request as draft January 31, 2024 17:17
@emersion
Copy link
Owner Author

Alright, let's keep this for later then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emersion @alebastr