Readme: Improved Running section #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have extracted "Multiple notification daemons" to another section. Also I have added a line explaining that mako needs a session bus. Later I have split systemd and non-systemd systems into two paragraphs
|
Hm… I'm not sure how this patch improves the readability? |
|
It added a separate section for running with multiple notification daemons and clearly separated systemd section from nonsystemd.
I think this makes the text more clear in a way that reader finds what they want quickly.
…-------- Original Message --------
On 3/18/24 12:50, Simon Ser 'notifications at github.com' wrote:
Hm… I'm not sure how this patch improves the readability?
—
Reply to this email directly, [view it on GitHub](#508 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A5VTOEWYLNYJMHK3NL2M3R3YY3IJHAVCNFSM6AAAAABE3NMGXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTG4YDMNZVGI).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have extracted "Multiple notification daemons" to another section.
Also I have added a line explaining that mako needs a session bus.
Later I have split systemd and non-systemd systems into two paragraphs
Related to #507
PS. Sorry for the fuss, I don't really have experience with stuff like that