-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use superagent from npm. #59
Conversation
I'm pretty sure superagent.js is a browserified build of an old superagent version. It's only used once in slackin-extended/assets/client.js Lines 45 to 65 in a08fb6c
Judging by the year I'd say the version was 2.x. So, now it will be 3.8.3. https://github.com/visionmedia/superagent/releases/tag/v3.0.0, which we should be OK. That being said we can just use XHR later and get rid of the dependency for the frontend. But before we proceed with merging this I'd like to revert any changes we made to the file. I'll make a PR in a few. |
NVM it was easier to push it here. Just don't squash the patches :) Also note that I haven't actually been able to test this myself. |
Instead ignore the file in ESLint since it appears to be a third-party file.
@emedvedev remember not to squash this |
Actually wait, it seems superagent.js isn't found on Now with this patch. Works fine locally though. |
Yup :) It also doesn't currently work with Now, trying to fix. |
There is an upstream patch for Now rauchg/slackin#399. Maybe this helps you simplify the Now deployment. |
Updated it to work with Now, too. |
Needs testing
Closes #58