vite: change ext-es format #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a good solution to the problem. I don't want to break the vite resolver every time core decides to add a search param. And what happens if core is using a searchParam but then vite decides to also start using the same name? We probably don't need to use search params at all in the core. The structure of these URLs were fairly arbitrary decisions. I I think we can make them all part of the pathName, and decide to leave searchParams entirely free for use by the host environment (vite). |
patricklx
changed the title
|
@ef4 I updated the pr, the failing checks look unrelated. more related to babel plugin template compilation |
|
Thanks, looking good. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.