Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scenario-tester #1897

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update scenario-tester #1897

wants to merge 2 commits into from

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented May 1, 2024

No description provided.

@ef4 ef4 added the internal label May 1, 2024
@mansona mansona marked this pull request as draft May 14, 2024 11:03
@mansona
Copy link
Member

mansona commented May 14, 2024

This is blocked on: stefanpenner/node-fixturify-project#97 for the majority of the tests

for the jest suites failures, I looked into it yesterday and it seems like the issue is related to @embroider/macros being considered a monorepo dependency when added to a project. I find this surprising because would have only thought that this would affect linkDependency not addDependency 🤔

the relevant line is: https://github.com/embroider-build/embroider/blob/update-scenario-tester/packages/macros/tests/babel/dependency-satisfies.test.ts#L139

@mansona
Copy link
Member

mansona commented May 20, 2024

This has already been applied on main 👍

@mansona mansona closed this May 20, 2024
@mansona mansona deleted the update-scenario-tester branch May 20, 2024 17:16
@mansona mansona restored the update-scenario-tester branch May 20, 2024 17:22
@mansona
Copy link
Member

mansona commented May 20, 2024

Sorry I was mistaken 🤔 I thought we had upgraded to 4.0 on main. I'm re-opening this but I'm hoping to get this upgraded on stable so maybe we can forward-port from there: #1931

@mansona mansona reopened this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants