Skip checking optional peer deps during dependency-validation #1829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I'm still debugging
Most immediately, this affects ember-data 4.12.5 (not usable in embroider because they have optional peers (or maybe not-correctly-forwarded peers?).
I don't know if this is the solve, as I don't really know haw to reason about checking if an optional peer declaration is correct or not. Feels like it may depend on runtime -- like if module loading happens pull on the optional peer deps -- so maybe skipping optional peers here is the best we can do?
Open to suggestions