Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip checking optional peer deps during dependency-validation #1829

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Feb 29, 2024

Draft because I'm still debugging

Most immediately, this affects ember-data 4.12.5 (not usable in embroider because they have optional peers (or maybe not-correctly-forwarded peers?).

I don't know if this is the solve, as I don't really know haw to reason about checking if an optional peer declaration is correct or not. Feels like it may depend on runtime -- like if module loading happens pull on the optional peer deps -- so maybe skipping optional peers here is the best we can do?

Open to suggestions

@NullVoxPopuli NullVoxPopuli changed the title Skip checking optional peer deps during dependency-validatior Skip checking optional peer deps during dependency-validation Feb 29, 2024
@ef4
Copy link
Contributor

ef4 commented Feb 29, 2024

My first intuition here is that if a package declares an optional peer dep, it's OK for the dep to be not-present, but it's not ok for it to be present and not-the-same as what your peer packages are using.

So if we error for missing optional peer deps today, that is a bug we can fix. But if we're erroring because an optional peer is present-and-wrong, it's not a bug in the checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants