Define local types for @embroider/core, since we have no guarantees of the consuming test environment #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with ESM conversion because when our packages type check, they don't (and can't) know if they're going to be used in a Jest or QUnit test environment (or maybe an environment without either of those global types).
The approach here is that we define only what we use for when we receive args, and globals are accessed on
globalThis, which we can cast to any, because we can't know what's on there.If we want to generate all types for
@embroider/addon-devin #1766, we'll need to make sure no package that@embroider/addon-devdepends on (nor sub-packages) rely on globally provided types.This has worked historically for us so far due to a global and single type-checking command with every set of types available at once (which is representative of how our packages can be used 😅 )