refactor: change isProduction check strategy #1793
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I aim to essentially change the way Embroider checks whether we're building for
production
. In anEmberApp
there's aisProduction
which basically does aenvironment === 'production'
. This shouldn't affect anything really.It's just that we aim to override this
isProduction
in our app because we have a different notion ofisProduction
. We have environment === 'staging', environment === 'native-app' for which we still want Embroider to run it's production optimization logic.