Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual entry point #1779

Merged
merged 29 commits into from May 16, 2024
Merged

Virtual entry point #1779

merged 29 commits into from May 16, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Feb 1, 2024

This PR is to move the assets/app-name.js entry point into virtual content. This means that it doesn't need to be done in Stage 2 any more

Thinks to do before this is merged:

  • implement lazy routes
  • delete old implementation (stage 2)
  • update entry-point target (i.e. have the script in index.html actually target #embroider-entrypoint)
  • implement static-app-paths config
  • implement fix extension resolving for esbuild #1827 for the audit system
  • move the CI to all use vite (and extract it to a new PR that could be merged first)

@mansona mansona marked this pull request as draft February 1, 2024 09:38
@mansona mansona self-assigned this Feb 1, 2024
@mansona mansona force-pushed the virtual-entry-point branch 2 times, most recently from 7dfa09d to caffd53 Compare February 1, 2024 17:41
@mansona mansona force-pushed the virtual-entry-point branch 6 times, most recently from 96c2927 to 425215f Compare February 29, 2024 14:22
@mansona mansona force-pushed the virtual-entry-point branch 4 times, most recently from 2b2e51f to 23f342b Compare March 7, 2024 11:54
@mansona mansona force-pushed the virtual-entry-point branch 4 times, most recently from 44981c2 to 00e95a1 Compare March 12, 2024 14:38
@mansona mansona force-pushed the virtual-entry-point branch 4 times, most recently from 74b2ea3 to 7d5f0b6 Compare April 9, 2024 13:57
@mansona mansona force-pushed the virtual-entry-point branch 2 times, most recently from 0e7cd03 to d593169 Compare April 11, 2024 16:45
@mansona mansona mentioned this pull request Apr 15, 2024
4 tasks
@mansona mansona marked this pull request as ready for review May 16, 2024 11:35
@mansona mansona added the enhancement New feature or request label May 16, 2024
@mansona mansona merged commit f469b9f into main May 16, 2024
178 checks passed
@mansona mansona deleted the virtual-entry-point branch May 16, 2024 13:52
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants