New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual entry point #1779
Merged
Merged
Virtual entry point #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
virtual-entry-point
branch
2 times, most recently
from
February 1, 2024 17:41
7dfa09d
to
caffd53
Compare
mansona
force-pushed
the
virtual-entry-point
branch
from
February 8, 2024 17:48
5845a0c
to
bbfafac
Compare
mansona
force-pushed
the
virtual-entry-point
branch
6 times, most recently
from
February 29, 2024 14:22
96c2927
to
425215f
Compare
mansona
force-pushed
the
virtual-entry-point
branch
4 times, most recently
from
March 7, 2024 11:54
2b2e51f
to
23f342b
Compare
mansona
force-pushed
the
virtual-entry-point
branch
4 times, most recently
from
March 12, 2024 14:38
44981c2
to
00e95a1
Compare
mansona
force-pushed
the
virtual-entry-point
branch
from
April 2, 2024 13:56
00e95a1
to
f61220a
Compare
mansona
force-pushed
the
virtual-entry-point
branch
4 times, most recently
from
April 9, 2024 13:57
74b2ea3
to
7d5f0b6
Compare
mansona
force-pushed
the
virtual-entry-point
branch
2 times, most recently
from
April 11, 2024 16:45
0e7cd03
to
d593169
Compare
mansona
force-pushed
the
virtual-entry-point
branch
from
May 16, 2024 11:34
af9b523
to
9b29b55
Compare
ef4
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to move the
assets/app-name.js
entry point into virtual content. This means that it doesn't need to be done in Stage 2 any moreThinks to do before this is merged:
#embroider-entrypoint
)