Skip to content

Commit

Permalink
Merge pull request #1912 from embroider-build/actions-warnings
Browse files Browse the repository at this point in the history
update all github actions to remove warnings about node version
  • Loading branch information
ef4 committed May 10, 2024
2 parents e8379dc + eace59d commit 9c504b3
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 21 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup/action.yml
Expand Up @@ -16,12 +16,12 @@ runs:
run: echo "auto-install-peers=false" > .npmrc
if: inputs.use_pinned_node == 'false'
shell: bash
- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v3
name: Install pnpm
with:
version: 8
run_install: false
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16
cache: pnpm
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -29,7 +29,7 @@ jobs:
matrix: ${{ steps.set-matrix.outputs.matrix }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: lint
run: pnpm lint
Expand All @@ -51,7 +51,7 @@ jobs:
matrix: ${{fromJson(needs.preflight.outputs.matrix)}}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
use_lockfile: false
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/publish-unstable.yml
Expand Up @@ -9,9 +9,6 @@ on:
branches:
- main

env:
VOLTA_FEATURE_PNPM: 1

concurrency:
group: publish-unstable-${{ github.head_ref || github.ref }}
cancel-in-progress: true
Expand All @@ -22,10 +19,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
registry-url: 'https://registry.npmjs.org'
Expand Down
12 changes: 6 additions & 6 deletions packages/util/.github/workflows/ci.yml
Expand Up @@ -18,9 +18,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 14.x
cache: yarn
Expand All @@ -37,8 +37,8 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14.x
cache: yarn
Expand Down Expand Up @@ -67,9 +67,9 @@ jobs:
- embroider-optimized

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 14.x
cache: yarn
Expand Down
12 changes: 6 additions & 6 deletions tests/addon-template/.github/workflows/ci.yml
Expand Up @@ -18,9 +18,9 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 14.x
cache: npm
Expand All @@ -37,8 +37,8 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 14.x
cache: npm
Expand Down Expand Up @@ -67,9 +67,9 @@ jobs:
- embroider-optimized

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 14.x
cache: npm
Expand Down

0 comments on commit 9c504b3

Please sign in to comment.