[BUGFIX #17529] Refactor get to return object or path #17973
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked issue #17529 and as suggested on the thread, it worked on the get property.
I wrote a new test based on the one from jasonmit and got it to pass, also all other test passed
Hope this will help, but any comment, suggestion or advice is welcome with open arms.
I am kind of new in the open source world so I hope I follow all of your contributing guides well but if I didn't it will be awesome if you could point out what I missed. Thanks :D