Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX #17529] Refactor get to return object or path #17973

Closed

Conversation

eplata31
Copy link

@eplata31 eplata31 commented Apr 25, 2019

I tracked issue #17529 and as suggested on the thread, it worked on the get property.
I wrote a new test based on the one from jasonmit and got it to pass, also all other test passed
Screenshot from 2019-04-25 11-44-41

Hope this will help, but any comment, suggestion or advice is welcome with open arms.
I am kind of new in the open source world so I hope I follow all of your contributing guides well but if I didn't it will be awesome if you could point out what I missed. Thanks :D

@pzuraq
Copy link
Contributor

pzuraq commented Apr 25, 2019

I'm not sure we should incur extra overhead for this, I think supporting periods in keynames was actually a bug and wasn't really intended behavior.

@jasonmit
Copy link
Member

jasonmit commented Apr 25, 2019

I'm not sure we should incur extra overhead for this, I think supporting periods in keynames was actually a bug and wasn't really intended behavior.

In dev mode, might be useful to throw with a helpful error message. It's not immediately clear what happened for those that do hit this while upgrading their apps. I can help land that if there's buy in.

@eplata31
Copy link
Author

I agree with @jasonmit and also it will be good to close the related issues to avoid confusion and extra work.

@AlexAndBear
Copy link

@pzuraq dot notation objects are fairly Common and i dont see a reason to let ember Break on a valid JSON

@locks locks added the wontfix label Feb 10, 2022
@locks
Copy link
Contributor

locks commented Feb 10, 2022

Sorry for the long turnaround! I think the ship has sailed on this 😅 We are trying to move off of EmberObject overall, too.

@locks locks closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants