Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yargs to 17.3.0 #2257

Merged
merged 1 commit into from Dec 2, 2021
Merged

Upgrade yargs to 17.3.0 #2257

merged 1 commit into from Dec 2, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Dec 2, 2021

This dependency release was breaking the next branch due to our floating dependencies test.

There's a change in the yargs-parser dep that changes the handling of quotes inside CLI option value strings. So we have to fix our test to remove the extra quotes.

https://github.com/yargs/yargs-parser/blob/main/CHANGELOG.md#2100-2021-11-15
yargs/yargs-parser#407
https://github.com/yargs/yargs/blob/main/CHANGELOG.md#1730-2021-11-30

@bmish bmish added the dependencies Pull requests that update a dependency file label Dec 2, 2021
@bmish bmish merged commit 2aa56c0 into ember-template-lint:next Dec 2, 2021
@bmish bmish deleted the yargs-17.3 branch December 2, 2021 14:46
@bmish bmish added the internal label Dec 2, 2021
@bmish bmish changed the title Update yargs to 17.3.0 Upgrade yargs to 17.3.0 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant