Update the Super Rentals Tutorial to use the Request Service #238
+94
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to avoid confusion around model names. Previosly JsonApiSerializer was singularizing type of every json-api response object, so convention "model name should be singular always was met. In new world, we don't do automatic conversion of payloads and try to have them as close as possible to network response. So if application developers do not manually add singularization of json-api response objects type - it will never happen. Therefore expected model name would be plural, or in better words match type from payload.
gitKrystan
approved these changes
May 10, 2024
runspired
reviewed
May 10, 2024
runspired
approved these changes
May 10, 2024
Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
IgnaceMaes
reviewed
May 24, 2024
IgnaceMaes
reviewed
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
Brings updates to Chapter 11 of tutorial.