-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
update node version to 16 for ember-beta #226
base: main
Are you sure you want to change the base?
Conversation
feeed55
to
f71140c
Compare
# Conflicts: # src/lib/walker.ts
So I think I need a bit of help to continue with this one. For some reason the git diff isn't applying in the CI environment but it is applying properly locally 馃 I thought it might be an issue with a difference between my git version locally and the one in the github actions but I tried updating both and it didn't seem to do anything 馃槥 One thing that I noticed is that the git diff looked a bit odd locally, it had some extra stuff that looked like it shouldn't be there. @@ -9,2 +9,3 @@ module.exports = function (environment) {
EmberENV: {
+ RAISE_ON_DEPRECATION: true,
FEATURES: { The Any help here would be much appreciated 馃帀 |
@@ -90,7 +90,7 @@ del package.json | |||
@@ -9,2 +9,3 @@ | |||
EmberENV: { | |||
+ RAISE_ON_DEPRECATION: true, | |||
EXTEND_PROTOTYPES: false, | |||
FEATURES: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where this change is coming from -- afaict new apps on v5.0.0 still have EXTEND_PROTOTYPES: false,
as the next line here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange 馃 I must have a local dependency issue
#227 pulled in your node update -- did you want to land any of the other changes in this PR or should it be closed? |
Since ember-cli@5 requires a minimum of Node@16 I have updated that in our volta pin 馃憤