Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove templateName and renderTemplate documentation #1445

Merged
merged 3 commits into from Jun 1, 2020
Merged

Conversation

locks
Copy link
Contributor

@locks locks commented May 30, 2020

Fixes #1442.

@locks locks requested a review from a team May 30, 2020 11:04
@jaredgalanis
Copy link
Member

jaredgalanis commented May 30, 2020

@locks I wonder if the test failure is related the node version? or potentially babel/preset-env?
see: storybookjs/storybook#10477

@jaredgalanis
Copy link
Member

@locks I wonder if the test failure is related the node version? or potentially babel/preset-env?
see: storybookjs/storybook#10477

confirmed that pinning to node 12.16.1 fixes the issue. see: #1447

fix node at version 12.16.1 to repair build issues
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@locks locks merged commit bdfba32 into master Jun 1, 2020
@locks locks deleted the locks-patch-1 branch June 1, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mention of templateName / renderTemplate from Route section
2 participants