first take on per-test qunit splitting #119
Open
+41
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an example of how we could support per-test test splitting for qunit. I would like to get feedback on the approach and whether it has some future so I could continue working on it. It breaks mocha so I am interested in thoughts on that as well.
|
Just to note, I am willing to work on getting it done for Mocha as well if this approach is ok with you. |
|
No problem, thanks for taking time to comment :). Looking forward to make it work for everybody. |
trentmwillis
requested changes
Nov 3, 2017
There was a problem hiding this comment.
Overall, seems like a reasonable approach. However, I'd like to ensure we maintain support for both QUnit and Mocha and the current implementation looks pretty tightly coupled to QUnit. So, there will likely need to be some sort of framework detection.
If you can get the tests passing, I'll do a more thorough review.
|
I will try to get them passing next week. It is possible I will need a little bit of help. If that happens, will communicate through comments here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how we could support per-test test splitting for
qunit. I would like to get feedback on the approach and whether it has
some future so I could continue working on it.
It breaks mocha so I am interested in thoughts on that as well.
Tests failing: unit tests of TestLoader.