feat!: parse json error response #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Tomic <16724532+boristomic@users.noreply.github.com> BREAKING CHANGE: Error response is parsed as JSON if response headers have content-type application/json and if it's possible to parse the data as JSON. Otherwise response will be retuned as string or default response will be returned as empty string.
eakraml
approved these changes
Dec 4, 2023
Signed-off-by: Boris Tomic <16724532+boristomic@users.noreply.github.com>
eakraml
approved these changes
Dec 4, 2023
jpersson
reviewed
Dec 7, 2023
This reverts commit b768554.
|
🎉 This PR is included in version 21.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #66
Signed-off-by: Boris Tomic 16724532+boristomic@users.noreply.github.com
BREAKING CHANGE: Error response is parsed as JSON if response headers
have content-type application/json and if it's possible to parse the
data as JSON. Otherwise response will be retuned as string or default
response will be returned as empty string.