Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #176
Solution
A user can specify a
pathRewrite
object in a proxy definitionto proxy requests from
"/api"
to"http://localhost:3000"
.The behavior is based on the
pathRewrite
option inhttp-proxy-middleware
where the first matching pattern determines the rewrite: https://github.com/chimurai/http-proxy-middleware/blob/f2a0af329969f8a70b3967a969146758a73d8b0e/src/path-rewriter.ts#L33-L39Notes
I tested this locally by running
elm-land server
with proxy options supported by the existing implementation, and again with the newpathRewrite
option, and proxying behaves as expected in both cases. I don't know how to add tests for this 😅 I'd be open to suggestions.