feat: add support for base tag #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elm-land ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
oh duplicate: #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is not possible to set the base tag in elm land.
Solution
Read base Tag attributes from elm-land.json and add to index.html template
Notes
Tested manual all 4 combinations of href and target attributes. Could not get the bats test to test what I wanted (content of generated index.html should contain ...)
New attributes not used in any example project right now. I was not sure about adding an example project just for that. And use in other examples might lead to unexpected behaviour.