Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customizations view:elm-ui and view:elm-css #145

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

nilskuhn
Copy link
Contributor

@nilskuhn nilskuhn commented Oct 8, 2023

I am not quite sure if matheus23/elm-default-tailwind-modules really is an alternative to customize the View module like elm-ui and elm-css are. At least it confused me a bit that it is described in the guide like that. I am using elm-default-tailwind-modules together with elm-css to use tailwind classes as styles.

But it's totally possible, that I am missing something and a customized View module leveraging elm-default-tailwind-modules makes sense.

@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for elm-land ready!

Name Link
🔨 Latest commit a244a72
🔍 Latest deploy log https://app.netlify.com/sites/elm-land/deploys/6533dedc5c387b0008927ea0
😎 Deploy Preview https://deploy-preview-145--elm-land.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ryan-haskell ryan-haskell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks awesome! 💯

Approving this now, and will merge soon when the next minor release is ready. I want to make sure we don't accidentally deploy the docs until v0.19.5 is out.

@ryan-haskell ryan-haskell merged commit 01c83df into elm-land:main Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants