Use onMouseDown
instead of onClick
#113
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the code provided in
Dropdown.elm
doesn't work as expected.If you try to select an item, you'll notice that the only thing that is being called is the
onBlur
handler. The reason behind this is that theblur
event precedes theclick
event (which internally callsmousedown
andmouseup
). When theblur
event is called, the menu along with its items gets destroyed, thus eliminating theonClick
handler.One solution is to replace
onClick
withonMouseDown
. Although it gets the job done, the UX is not ideal (especially when considering a11y). Since this tutorial is just for demo purposes, I believe it's okay to make this sacrifice.