Stop using contains for queries which use labels to match #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and there is a check that labels have a for attribute. Hmm... I'll look into that. |
|
@joelbyler Thanks for working on this! I'm sorry about the xpath stuff. It's gross. I originally intended on building a library to compose xpath queries but never made time for it. I haven't come up with a better solution yet but if you have thoughts I'd be interested in hearing them. |
|
Hi guys 馃槃 is this still relevant? I would love to align this PR with the latest master if needed 馃槉 P.S: thanks a lot for this great library! 馃檱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the perfect fix for #306 but I was able to get the new test to pass using this revised xpath. That thing is so hard to follow though, I'm sure I might have missed something. I'm opening this in the hopes to start a conversation about fixing this issue and I'm glad to help out. If this does actually fix the issue then 馃帀, but I'm betting there's more to it.
Also, what are your thoughts on making that xpaths easier to parse visually? I spent some time breaking bits of it apart locally but didn't commit any of that here. Perhaps I can offer some help there to lower the bar of entry for others, let me know.
Thanks for reviewing and thanks in advance for your feedback!