Make take_along_axis an optional callback #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still yet to implement the default implementation. Hence the failing tests. |
josevalim
reviewed
May 12, 2024
| ^axis -> Value.reshape(indices, new_axis_typespec) | ||
| axis -> Value.iota(state.builder, axis, new_axis_typespec) | ||
| end) | ||
| |> Value.concatenate(indices_rank, full_indices_typespec) |
There was a problem hiding this comment.
FWIW, this is the main transformation you need to make in order to convert take_along_axis into a gather. :) If you do this transformation and call gather without the axes option, it should be equivalent to the work done here.
Benjamin-Philip
force-pushed
the
bp-make-take-along-axis-optional
branch
from
ba1a17c
to
3da08f3
Compare
|
@josevalim, I've committed that transformation. I'm having some trouble making the optional callback work in |
josevalim
reviewed
May 13, 2024
josevalim
reviewed
May 13, 2024
josevalim
reviewed
May 13, 2024
Benjamin-Philip
force-pushed
the
bp-make-take-along-axis-optional
branch
from
0863a3c
to
3da08f3
Compare
|
@Benjamin-Philip you can also remove the implementations from |
|
Fixed and pushed manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes take_along_axis an optional callback, using the default
implementation for BinaryBackend and EXLA, and a custom one for
Torchx.
Closes #1366.