Internal: Make AI promotions less intrusive [ED-14582] #27283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netanelavr
previously approved these changes
May 9, 2024
| @@ -146,7 +146,7 @@ export default class AiBehavior extends Marionette.Behavior { | |||
| return; | |||
| } | |||
|
|
|||
| if ( ! shouldShowPromotionIntroduction() ) { | |||
| if ( ! shouldShowPromotionIntroduction( sessionStorage ) ) { | |||
There was a problem hiding this comment.
where this sessionStorage is coming from?
There was a problem hiding this comment.
window global context
matipojo
requested changes
May 12, 2024
| } ); | ||
|
|
||
| it( `Should return false when previous promotion appeared less than ${ HOURS_BETWEEN_PROMOTION_INTRODUCTIONS } hours ago`, async () => { | ||
| const currentDate = new Date( 2024, 5, 3, 15 ); |
There was a problem hiding this comment.
The test will not work after Jun, 03 2024
DennisNerush
force-pushed
the
ED-14582-internal-make-ai-promotions-less-intrusive
branch
from
7972502
to
9cca5a6
Compare
matipojo
previously approved these changes
May 12, 2024
DennisNerush
force-pushed
the
ED-14582-internal-make-ai-promotions-less-intrusive
branch
from
871c317
to
89c17bd
Compare
netanelavr
approved these changes
May 15, 2024
DennisNerush
added a commit
to DennisNerush/elementor
that referenced
this pull request
May 15, 2024
DennisNerush
added a commit
to DennisNerush/elementor
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.