Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CSS fails “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights #27202

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

2aragorn
Copy link

@2aragorn 2aragorn commented May 1, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

  • Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights

Description

An explanation of what is done in this PR

  • Added "font-display: swap;" to relevant CSS classes.

Test instructions

This PR can be tested by following these steps:

  • Use Google PageSpeed to analyze a website using Elementor. (https://pagespeed.web.dev/)
  • Check the "Performance" tab
  • Check the sources of the "Ensure text remains visible during webfont load" error
  • One of the sources will be /wp-content/plugins/elementor/assets/lib/eicons/css/elementor-icons.css

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights. As referenced here: https://wordpress.org/support/topic/simple-fix-ensure-text-remains-visible-during-webfont-load/#post-17715711
Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights. As referenced here: https://wordpress.org/support/topic/simple-fix-ensure-text-remains-visible-during-webfont-load/#post-17715711
Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights. As referenced here: https://wordpress.org/support/topic/simple-fix-ensure-text-remains-visible-during-webfont-load/#post-17715711
@CLAassistant
Copy link

CLAassistant commented May 1, 2024

CLA assistant check
All committers have signed the CLA.

@2aragorn 2aragorn changed the title Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights Fix: CSS fails “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants