New: Implement caching mechanism on render elements [ED-13883] #25730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elementor into tweak/ED-13883-elements-cache
…elementor into tweak/ED-13883-elements-cache
…elementor into tweak/ED-13883-elements-cache
rodolphebertozzo
suggested changes
Apr 17, 2024
|
Works really nice, performance increase is hugh in my tests |
arielk
previously approved these changes
May 12, 2024
rotemee
previously requested changes
May 13, 2024
| @@ -75,6 +81,9 @@ public function add_assets( array $assets ) { | |||
| $this->assets = array_replace_recursive( $this->assets, $assets ); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated 3.22.0 | |||
| */ | |||
There was a problem hiding this comment.
@KingYes - Not sure I understand the latest changes related to the loader, I see that you've restored the call to enqueue_assets(), but why not go with the direction that you need?:
- enqueue_assets - will enqueue immediately (and not deprecated).
- enable_assets - will point to the enqueue_assets() and will be marked as deprecated.
- add_assets - will also register the assets.
In other words to get rid of the "pre-enabled" capability if it's not needed?
|
|
louiswol94
force-pushed
the
tweak/ED-13883-elements-cache
branch
from
1143ede
to
d460607
Compare
louiswol94
reviewed
May 13, 2024
louiswol94
reviewed
May 13, 2024
louiswol94
reviewed
May 13, 2024
louiswol94
approved these changes
May 13, 2024
arielk
approved these changes
May 13, 2024
KingYes
added a commit
that referenced
this pull request
May 13, 2024
Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com> Co-authored-by: Louis Wolmarans <louiswol94@gmail.com>
arielk
pushed a commit
that referenced
this pull request
May 13, 2024
… (#27305) Co-authored-by: ElementorBot <48412871+elementorbot@users.noreply.github.com> Co-authored-by: Louis Wolmarans <louiswol94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.