Fix webview scroll #973
Open
Fix webview scroll #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danirabbit Is this a viable approach? Or as elementary 8 is not too far off (hopefully) can this bug remain until we see if it resolved by upstream updates? |
|
Up: Mail is practically unusable since September, a weird temporary fix is still better than a broken app, isn't it? Would be happy if you considered releasing this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950
The currently used version of WebView does not interact properly with Gtk's size allocation when buried inside a scrolled window inside a revealer inside a listbox ...
The only solution I could find was to not show the webview within the list box but to show it in a separate pane of of a Gtk.Paned so that the native scrolling ability of WebView is used. Clearly, this changes the UI significantly so may not be acceptable but at least the message contents of long messages are always visible.
Image shows a thread with 4 messages. The most recent message header is shown expanded, the rest are below it in a scrolled window (i.e. reversed order compared to master). This is because of problems controlling where the divider of the vertical pane is placed automatically.