Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the compositor be the first program to launch #726

Merged
merged 3 commits into from
May 20, 2024

Conversation

tintou
Copy link
Member

@tintou tintou commented May 14, 2024

Allows to make sure that the greeter will be launched when the compositor is ready, also allow us to use the right API on wayland.

@danirabbit
Copy link
Member

Yay thank you! I keep meaning to look into this so that's really appreciated 🩷

@tintou
Copy link
Member Author

tintou commented May 14, 2024

Anyone can feel free to take over this MR as I only have limited time currently 👍

@tintou tintou marked this pull request as ready for review May 17, 2024 09:57
@tintou
Copy link
Member Author

tintou commented May 17, 2024

It is actually working when removing the switch to Gtk.Application so yay!

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it does work!

For some reason my install has started not starting the panel in either the greeter or the main session 🤔 so I don't know what's the cause. But also I'm not getting the wallpaper on the greeter anymore either. I can't confirm if it's related to this branch unfortunately.

But, this does seem to solve a major issue where sometimes the screen would just be black or only partially faded in. So functionally this is a big fix. I'd be in favor of merging and figuring out those regressions separately if anyone else is experiencing them.

Just one inline comment :)

Comment on lines 88 to 92
fade_in_screen.save_easing_state ();
fade_in_screen.set_easing_duration (1000);
fade_in_screen.set_easing_mode (Clutter.AnimationMode.EASE);
fade_in_screen.opacity = 0;
fade_in_screen.restore_easing_state ();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for removing the fade in? This branch seems to still work with it

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes to fadein. If that's important for something please propose it again separately :)

@danirabbit danirabbit merged commit 6540118 into master May 20, 2024
4 checks passed
@danirabbit danirabbit deleted the tintou/compsitor-first branch May 20, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants