Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gettext: Checkout the repository using the elementaryBot token #962

Closed
wants to merge 1 commit into from

Conversation

tintou
Copy link
Member

@tintou tintou commented Nov 9, 2020

No description provided.

@davidmhewitt
Copy link
Member

I think something else is wrong here because the gettext action already sets the token passed via env var on the remote:
https://github.com/elementary/actions/blob/master/gettext-template/entrypoint.sh#L35

@tintou
Copy link
Member Author

tintou commented Nov 9, 2020

I've applied this to calendar and it worked there https://github.com/elementary/calendar/commits/master
the GitHub checkoutv2 action is probably setting the credentials using a different method

@davidmhewitt
Copy link
Member

Had a look into that and opened an issue here:
elementary/actions#55

I think that should work, but I haven't tested it anywhere. But hopefully it's better to fix it there rather than having to go and make this change in every repo.

@jeremypw
Copy link
Contributor

@tintou Is this PR still potentially useful or will the issue be fixed upstream?

@tintou tintou closed this May 27, 2021
@tintou tintou deleted the tintou/fix-action branch August 31, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants