[GTK4 Prep] Update DocumentView to use Hdy.TabView #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for the DocumentView widget
jeremypw
reviewed
Feb 29, 2024
…with Hdy.TabView DocumentView
…e right tab menu is opened
colinkiama
requested review from
a team and
jeremypw
and removed request for
a team
colinkiama
changed the title
jeremypw
requested changes
Mar 24, 2024
There was a problem hiding this comment.
Thanks for working on this. It mostly works now, just a couple of things I notice:
- The tab background colour does not follow the "solarized light" theme (unlike
main). - The
tab_historybutton is not connected up. This button does not seem to be working inmaineither but if we are going to add it again here we might as well have it working.
|
I've addressed the additional feedback you had. |
…if no Document object is passed in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentView widget has been rewritten to use the
Hdy.TabViewwidget.The majority of the work is done. There are a few more things that left to do but I haven't figured out how to do these yet (Any help would be very appreciated!):
Part of #1157