Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValaSymbolOutline: Lose global header #1409

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeremypw
Copy link
Collaborator

Fixes #378

Because SourceList requires the toplevel items to be headers, it seems, it was necessary to add another header "Other Symbols" when there are symbols that would not otherwise appear (e.g. those outside of classes or an existing namespace). This complicates the code significantly.

The CSymbolOutline was not touched as there are usually a large number of symbols at the top level.

@danirabbit
Copy link
Member

I'm not sure if this really solves the issue since in most cases we just end up with another single toplevel item. Perhaps we should revisit this after/as part of GTK 4 porting not using SourceList?

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jan 20, 2024

@danirabbit I think solves the issue as strictly stated in the original report in that it gets rid of the redundant "Symbols" header which has nothing to do with the structure of the code. The presence of remaining topevel items reflects the structure of the code as returned by the parser so cannot be fixed without applying further rules to hide some Vala symbols and not others which I am 👎 on but, if desired, should be raised in (another) issue.

You're probably right that it would have been easier to address the original issue by changing the widget in Gtk4 but that will not in itself fix the expanded issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbols plugin has redundant header
2 participants