Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext: Use a git credential helper to set token #55

Open
davidmhewitt opened this issue Nov 9, 2020 · 0 comments
Open

gettext: Use a git credential helper to set token #55

davidmhewitt opened this issue Nov 9, 2020 · 0 comments
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice

Comments

@davidmhewitt
Copy link
Member

davidmhewitt commented Nov 9, 2020

The GitHub checkout@v2 action sets the credentials on the repo differently, meaning that doing this does not work anymore:

git remote set-url origin https://x-access-token:"$GITHUB_TOKEN"@github.com/"$GITHUB_REPOSITORY".git

This means that the action can no longer push to protected branches using the elementaryBot token.

Reading this suggests that adding a git credential helper instead should be the solution to this problem:
actions/checkout#162

So it looks like we can add something like this instead:

git config credential.https://github.com/.helper "! f() { echo username=x-access-token; echo password=$GITHUB_TOKEN; };f"
@davidmhewitt davidmhewitt added Priority: Wishlist Not a priority, but something that might be nice Needs Design Waiting for input from the UX team labels Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice
Projects
None yet
Development

No branches or pull requests

1 participant