Loosen the version constrain of the click package #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
|
@oravi Sorry for bothering you. What are your thoughts on the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I got the error message to install elementary in addition to dbt-core. I assume that is caused by the difference of the version constrains of the click package in dbt-core and elememtary. I would expect pip appropriately handle the version constrains in both of dbt-core and elementary. But, sometimes it doesn't work. In my opinion, we are probably loosen the version constrains so that we can also catch up with new releases of click. The latest version is today 8.1.7.
https://github.com/dbt-labs/dbt-core/blob/c86cec3256cfeb636d47f21279f3cb689d585439/core/setup.py#L62