New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [carousel] height is adaptive when height is auto #11392
Conversation
…/element-plus into carousel-height-auto
👋 @qq282126990, thank you for contributing element-plus. |
Hello @qq282126990, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=11392 |
Just so you know that there were users who use this component and the changes you made might change the default behavior for those users per @btea's question above. Marking this behind a flag would be more flexible. |
ok, I feel that I need to add a new attribute named auto-height to delete and modify height to 'auto' |
I don't think it is necessary to add new attributes, the default value of |
So should I keep my original judgment? |
@jw-foss Using the test case, I don’t know why the height of the element cannot be obtained |
hello, Here is the test case I wrote One problem is that running the test case carousel-item cannot get offsetHeight |
这个特性可用了么? |
This seems to be a jsdom bug, refer here. |
ok ,i see |
@qq282126990 There seems to be a conflict in the code, can you fix it? |
ok |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.