Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lemonldap-NG OIDC config #17204

Merged
merged 2 commits into from
May 22, 2024
Merged

Update Lemonldap-NG OIDC config #17204

merged 2 commits into from
May 22, 2024

Conversation

guimard
Copy link
Contributor

@guimard guimard commented May 16, 2024

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Signed-off: Xavier Guimard <xguimard@linagora.com / yadd@debian.org>

@guimard guimard requested a review from a team as a code owner May 16, 2024 03:19
@CLAassistant
Copy link

CLAassistant commented May 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot deployed to PR Documentation Preview May 17, 2024 10:08 Active
erikjohnston
erikjohnston approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston erikjohnston enabled auto-merge (squash) May 22, 2024 12:21
@github-actions github-actions bot deployed to PR Documentation Preview May 22, 2024 12:22 Active
@erikjohnston erikjohnston merged commit a547b49 into element-hq:develop May 22, 2024
32 checks passed
H-Shay pushed a commit to H-Shay/hq_synapse that referenced this pull request May 31, 2024
@guimard @H-Shay
Update Lemonldap-NG OIDC config (element-hq#17204)
b19e2cd 
Update OIDC documentation: by default Matrix doesn't query userinfo endpoint, then claims should be put on id_token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guimard @CLAassistant @erikjohnston